Error in #include file "C:\AFC-master\Lib\CWindow.ahk":
     Parameter #2 invalid.
...
--->	065: Gui,%h%:Add,%ctrlName%,hwndctrlHwnd %glabelAttr% v#%pCtrl% %options%,value

;add just below this line: pCtrl := &oCtrl, ctrlName := oCtrl.__CtrlName, glabelAttr := "g__CWindowGlabel"

if (ctrlName = "") && (options = "xs Section")
	ctrlName := "ListView"
else if (ctrlName = "") && (options = "r7")
	ctrlName := "TreeView"

I get this error when I try to run Example-ManyControls.ahk:
[code]
Error in #include file "C:\AFC-master\Lib\CWindow.ahk":
Parameter #2 invalid.
...
---> 065: Gui,%h%:Add,%ctrlName%,hwndctrlHwnd %glabelAttr% v#%pCtrl% %options%,value
[/code]
The problem is that the variable ctrlName is blank. A workaround (that works with the latest AHK, v1.1.26.01) is to add the following 4 lines:
[code]
;add just below this line: pCtrl := &oCtrl, ctrlName := oCtrl.__CtrlName, glabelAttr := "g__CWindowGlabel"

if (ctrlName = "") && (options = "xs Section")
ctrlName := "ListView"
else if (ctrlName = "") && (options = "r7")
ctrlName := "TreeView"
[/code]

I found that this script did work correctly using v1.1.15.02, but did not work correctly using v1.1.15.03.
See here to download old versions of AutoHotkey:
old versions of AutoHotkey - AutoHotkey Community
[url]https://autohotkey.com/boards/viewtopic.php?f=2&t=30206[/url]

The changelog says very little for this update:
Changes & New Features
[url]https://autohotkey.com/docs/AHKL_ChangeLog.htm#v1.1.15.03[/url]

[quote]Fixed meta-functions to exit the thread correctly after using Exit or Throw.

Fixed FileInstall to use A_WorkingDir when Dest is relative in a non-compiled script.[/quote]

I would be interested to understand why the problem occurs. Thanks for reading.

Upon further review, it appears that the syntax I mentioned above is only used in lines 488 and 501 in CCtrlListView.ahk and in line 505 in CCtrlTreeView.ahk. Regardless, I favor the solution where "RightClick" is used.

__CCtrlListView_OnEvent_DoubleClick:
__CCtrlListView_OnEvent_R:
return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "R"))

return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "R", true))
return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "RightClick"))

I found the following issues while using the CCtrlListView class in the function OnEvent(oCtrl, guiEvent, eventInfo):

[code=autohotkey file=Untitled.ahk]__CCtrlListView_OnEvent_DoubleClick:
__CCtrlListView_OnEvent_R:
return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "R"))[/code]

Since InStr() is not case-sensitive by default, the last parameter in the return statement needs additional clarity. The idea was that it would search for "RightClick" by finding "R", and perhaps InStr() was case-insensitive at the time the library was written, however it now needs to either add the case-sensitive parameter to InStr() or search for "RightClick" instead of "R" -- possible solutions would be as follows:

[code=autohotkey file=Untitled.ahk]return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "R", true))
return oCtrl.OnDoubleClick.(this, oCtrl, eventInfo, !!InStr(guiEvent, "RightClick"))[/code]

There are multiple lines in that file where this appears to be the case, including 488 and 501, however considering the number of functions that check GuiEvent in this file and possibly others, it is likely that this needs to be updated throughout the library.

	Gui, Add, Tab2,x0 y0 w1200 h300 buttons gtab vTab, 1|2|3|4|5|6|7|8|9|10
	ztab = 1
	loop 10
	{
		Gui,Tab, %ztab%
                ...
		Gui, Add, ListView, x5 y81 w900 h560 Count5000 Report gOpen vzlistview%A_Index% hwndhlistview%a_index% -readonly -lv0x20 altsubmit, File|Modified|Size|Type
                ...
		ztab++
	}
	ztab = 1
	gui, tab

Rename:
	Gui,Tab,%zTab%                     
	gui, listview, zlistview%ztab%
	RowNumber := LV_GetNext()     
	lv_modify(rownumber, "Focus")
	LV_GetText(renameoldName,RowNumber)           
	hlistview := hlistview%ztab%
	sendmessage, 0x1017, rownumber - 1, 0, , ahk_id %hlistview%	; lvm_editlabela
return

class MyWin extends CWindow
{
	__New()
	{
		base.__New("title")
		ctrlTab := new CCtrlTab(this, "1|2|3|4|5|6|7|8|9|10", "x0 y0 w600 h300 buttons altsubmit")
		loop, 10
		{
			ctrlTab.BeginDef(a_index)
                        ...
			this.listview["" a_index] := new CCtrlListView(this, "File|Modified|Size|Type|", "x5 y81 w830 h560 Count5000 Report")
                        ...
		}
		ctrlTab.EndDef()
                ...		
		this.Show()
	}
}

I have a gui with 10 listviews as tabs like
[code]
Gui, Add, Tab2,x0 y0 w1200 h300 buttons gtab vTab, 1|2|3|4|5|6|7|8|9|10
ztab = 1
loop 10
{
Gui,Tab, %ztab%
...
Gui, Add, ListView, x5 y81 w900 h560 Count5000 Report gOpen vzlistview%A_Index% hwndhlistview%a_index% -readonly -lv0x20 altsubmit, File|Modified|Size|Type
...
ztab++
}
ztab = 1
gui, tab
[/code]and I use the following subroutine, triggered by a menu, to enable the first field to [b]inline editing[/b]:
[code]
Rename:
Gui,Tab,%zTab%
gui, listview, zlistview%ztab%
RowNumber := LV_GetNext()
lv_modify(rownumber, "Focus")
LV_GetText(renameoldName,RowNumber)
hlistview := hlistview%ztab%
sendmessage, 0x1017, rownumber - 1, 0, , ahk_id %hlistview% ; lvm_editlabela
return
[/code]I am converting this code to AutoHotkey Foundation Classes, and I have problems to get the value for [b]ahk_id[/b] in the [b]sendmessage[/b] command.

Here is part of my CWindow class
[code]
class MyWin extends CWindow
{
__New()
{
base.__New("title")
ctrlTab := new CCtrlTab(this, "1|2|3|4|5|6|7|8|9|10", "x0 y0 w600 h300 buttons altsubmit")
loop, 10
{
ctrlTab.BeginDef(a_index)
...
this.listview["" a_index] := new CCtrlListView(this, "File|Modified|Size|Type|", "x5 y81 w830 h560 Count5000 Report")
...
}
ctrlTab.EndDef()
...
this.Show()
}
}
[/code]Can anyone here please lead me to the right direction? Thank you in advance.

Hubert

My only complaint is that this wasn't available a few years ago when I was playing with guis. This will definitely make it much quicker to create new scripts and keep them updated. Thanks fincs! :D

I suspect this to be an AHK bug.

First of all thank you for sharing this cool classes.

I can can confirm the error with ListView and the problem with the ListView Events, which do not work.
I am using V1.1.16.05 U32 with Win7.
But I think I made it work with the following changes:
I changed in the file CCtrlListView.ahk the [b]line 16[/b] from
static __CtrlName := "ListView"
to
[b]__CtrlName := "ListView"[/b]
This is somehow related to the sub class __Get (line 177). If you comment the sub class, the static works.

To make the events working, I changed in the file CWindow.ahk the [b]line 444[/b] from
oCtrl.OnEvent.(__CWindow_GetGui(), oCtrl, A_GuiEvent, A_EventInfo)
to
[b]oCtrl.OnEvent(__CWindow_GetGui(), oCtrl, A_GuiEvent, A_EventInfo)[/b]
by removing the second dot, which with my understanding changes it from a function reference to a method call.
With this change I had to change also the [b]line 480[/b] in the file CCtrlListView.ahk from
OnEvent(oCtrl, guiEvent, eventInfo)
to
[b]OnEvent(oGui, oCtrl, guiEvent, eventInfo)[/b]
Because the hidden "this" did not work here.
Therefore I changed also everywhere in this method "this" to "oGui".

This works for me, but maybe somebody can verify what I did (fincs?).
By the way this is a great example, which made me learning a lot about many specials around classes by studying it. ;)

bump

did anyone of the nearly 150 viewers test my code or fincs' example?

Thank you for this wunderful class (and for the wunderful SciTE4AutoHotkey, too) !!!

In order to learn about OOP with AutoHotkey and to get some experience I have converted the second (full) example of the TreeView section in the help and made some additions (folders and icons in the listview and doubleclick for treeview, listview and statusbar) and will share it here with this community:
[spoiler]#include <CCtrlLabel>
#include <CCtrlListView>
#include <CCtrlTreeView>
#include <CCtrlStatusBar>
#include <CPropImpl>
#include <CImageList>

AFC_Entrypoint(MyWin)

class MyWin extends CWindow
{
__New()
{
Random, ov, 1, 10000
base.__New("#" ov " - File Manager with AFC")

il := new CImageList(this, 5)
loop, 5
IL.AddImage("shell32.dll", A_Index)

this.TreeViewWidth := 280
tv := new CCtrlTreeView(this, "r20 w" this.TreeViewWidth)
tv.BindImageList(il)
tv.OnDoubleClick := this.tvDoubleClick
tv.OnSelect := this.tvSelect
tv.root := "D:\ahk_source" ; %A_StartMenuCommon%
tv.root := A_StartMenuCommon
this.tv := tv

this.ListViewWidth := A_ScreenWidth - this.TreeViewWidth - 30
lv := new CCtrlListView(this, "Name|Size|Modified", "x+10 r20 grid w" this.ListViewWidth)
lv.BindImageList(il)
lv.OnDoubleClick := this.lvDoubleClick
this.lv := lv
lv.AddRow(["Hello", "world!"])

this.Col2Width := 70
LV.ModifyCol(1, "N" this.ListViewWidth - this.Col2Width - 30)
LV.ModifyCol(2, "integer N" this.Col2Width)
tv.lv := lv

SplashTextOn, 200, 25, TreeView and StatusBar Example, Loading the tree...
this.AddSubFoldersToTree(tv.root, tv)
SplashTextOff

sb := new CCtrlStatusBar(this)
sb.OnClick := this.sbClick
SB.SetPartWidths(300, 85)
sb.SetPartText("Ready.!`tfoo.")
sb.SetPartText("Ready.", 2)
tv.sb := sb

this.setoptions("+resize")
this.onsize := this.guisize
this.onmaximize := this.guisize
this.Show()

AFC_AtExit(this.ExitRoutine1)
}

AddSubFoldersToTree(Ordner, tv, node := "")
{
Loop %Ordner%\*.*, 2 ; Retrieve all of Folder's sub-folders.
this.AddSubFoldersToTree(A_LoopFileFullPath, tv.Addnode(A_LoopFileName, "Icon4"))
}

lvDoubleClick(lv, row)
{
this.OwnDialogs()
MsgBox % lv.Item[row, 1] ", " lv.Item[row, 2]
lv.InsertRow(row+1, lv.RowData[row])
lv.AutoSizeCol()
}

tvDoubleClick(tv, node)
{
this.OwnDialogs()
t := "Children of " node.Text ":`n`n"
for i,child in node
t .= "[" i "]: " child.Text "`n"
MsgBox % t
}

sbClick(sb)
{
this.OwnDialogs()
MsgBox, Hey, you clicked me!
sb.SetPartText("You have already clicked me")
}

ExitRoutine1()
{
this.whatever := "Yeah, it worked."
MsgBox % this.whatever
}

tvselect(tv, node)
{
selecteditemtext := node.text
Loop
{
if !isobject(node.parent)
break
node := node.parent
parenttext := node.text
selecteditemtext = %parenttext%\%selecteditemtext%
}
SelectedFullPath := tv.root "\" selecteditemtext
tv.lv.clear()
tv.lv.setoptions("-Redraw")
SplashTextOn, 200, 25, TreeView and StatusBar Example, Folder is loading...
FolderCount = 0
Loop %SelectedFullPath%\*.*, 2
{
tv.LV.Addrow([A_LoopFileName, "", A_LoopFileTimeModified], "icon4")
FolderCount++
}
FileCount = 0
TotalSize = 0
Loop %SelectedFullPath%\*.*
{
tv.LV.Addrow([A_LoopFileName, A_LoopFileSize, A_LoopFileTimeModified], "icon1")
FileCount += 1
TotalSize += A_LoopFileSize
}
tv.lv.setoptions("+Redraw")
tv.lv.AutoSizeCol()
SplashTextOff
total := Round(TotalSize / 1024)
tv.SB.SetPartText(FileCount . (filecount = 1 ? " File" : " Files") . " / "
. FolderCount . (foldercount = 1 ? " Folder" : " Folders"))
tv.SB.SetPartText(Total . " KB", 2)
tv.SB.SetPartText(SelectedFullPath, 3)
}

guisize(w, h)
{
this.tv.move("H" . (h - 30))
this.lv.move("H" . (h - 30) . " W" . (w - this.tv.position.w - 30)) ; TreeViewWidth - 30))
}
}[/spoiler]
During this development I got the following error message:
[spoiler]Error in #include file "D:\ahk_source\forum\AFC2\Lib\CWindow.ahk":
Parameter #2 invalid.

Line#
061: pCtrl := &oCtrl, ctrlName := oCtrl.__CtrlName, glabelAttr := "g__CWindowGlabel"
064: if ctrlName in Progress,GroupBox
065: glabelAttr := ""
066: if !ctrlname
067: ctrlName := hud_ctrlname
068: if !ctrlname
069: ctrlName := octrl.special
---> 071: Gui,%h%:Add,%ctrlName%,hwndctrlHwnd %glabelAttr% v#%pCtrl% %options%,value
072: #%pCtrl% := ""
073: this.__Controls[ctrlHwnd] := oCtrl
074: Return,ctrlHwnd
075: }
078: {
079: h := this.__Handle
080: GuiControl,%h%:%cmd%,%ctrlID%,value

The current thread will exit.[/spoiler]
Debugging with SciTE4AutoHotkey showed that the field in the "tv" object contained "TreeView", but the field "ctrlName" is [b]empty[/b].

This also occurred with the listview and can also be produced with the AFC "Example-Many-Controls.ahk". Additional the event handlers like OnDoubleClick and OnSelect also do not work though the labels are contained in the objects. I think it is them same cause: when the handler is called the label field is empty. On the other side, Button, Edit, UpDown and Statusbar in the example (and Progress from the other example) work without problems.

In these tests I used [b]V1.1.16.04 to V1.1.16.06[/b] in the modes A32, U32 and U64 on XP, Win7 and Win8.1.

Then I checked [b][color=#FF4000]V1.1.14.03[/color][/b], my previous AHK version, in the same modes on the same systems [b]and it works[/b], so that I could finish my development.

[b]I think this is a bug in the last versions and I wonder if it should be posted in the appropriate section?[/b]

For the above noted errors I found a workaround with global variables and a change in CWindow class, but this does not work for event handlers.

Hubert

thanks, looks like AFC-master.zip includes library, documentation and examples all in one package.

The downloadable package contains 4 examples, their source can also be found online at GitHub.

any examples using AFC? :D

[color=gray][Repost][/color]

AFC is a thin object-oriented wrapper around some of AutoHotkey's functionality. It mainly takes care of wrapping long-time present commands and functions that use old and quirky paradigms into a saner and cleaner class-based API.

AFC is designed to be modular, and to be as direct as possible with the original API. This translates to not having otherwise obvious properties that are implemented through flexi-lists. I believe that the performance and code size penalty is not justified.

AFC provides:[list][*]Structured class-based entry points.
[*][b]GUI API[/b]
[*]Default base object, which provides OOP syntax sugar for non-object values (such as [c]str.Length[/c])[/list]
AFC will provide in the future:
[list]
[*]Menus
[*]Timers
[*]Hotkeys and hotstrings (perhaps?)[/list]

[size=150][url=https://github.com/fincs/AFC/archive/master.zip]Download[/url] - [url=https://github.com/fincs/AFC]GitHub[/url] - [url=http://fincs.ahk4.net/AFC-doc/]Documentation[/url][/size] ([url=http://fincs.ahk4.net/files/AFC-doc.zip]Download documentation[/url])

AFC's GUI API gets completely rid of:[list][*]g-labels and Gui event labels.
[*]Associated variable names.
[*]Gui names/numbers.
[*]Confusing subcommands.[/list]
Feel free to comment. Hope you enjoy! :D