GuiControl speed bug? Topic is solved

[Ravenlord]

Hi.

I'm not sure if this can be considered as a bug. But check this. If we do GuiControl with default speed then we have random effect/or don't work at all when we choose Test 1. (after adding Test 3 - this effect occurs on Test 1 and Test 2 etc...) .
It works, when we add Sleep between Guicontrols.

Code: Select all

#NoEnv
#SingleInstance force

Gui, Add, DropDownList, w100 vLista gGrupa, Test 1|Test 2
Gui, Add, Tab3, xs+1 -Theme vTabGrupa1, TEST|TEST 2|TEST 3|TEST 4
Gui, Tab
Gui, Add, Tab3, xm+0 -Theme vTabGrupa2, Szablon 1|Szablon 2|Szablon 3|Szablon 4
Gui, Show
Return

Grupa:
{
  Gui, Submit, nohide
  if (Lista = "Test 1")
  {
    GuiControl, Show, TabGrupa1
    GuiControl, Hide, TabGrupa2
    GuiControl, Hide, TabGrupa3
    GuiControl, Hide, TabGrupa4
  }
  else if (Lista = "Test 2")
  {
    GuiControl, Hide, TabGrupa1
    GuiControl, Show, TabGrupa2
    GuiControl, Hide, TabGrupa3
    GuiControl, Hide, TabGrupa4
  }
}
return

[just me]

For some reason it seems to work reliably here if you change the order of the GuiControl commands:

Code: Select all

#NoEnv
#SingleInstance force

Gui, Add, DropDownList, w100 vLista gGrupa, Test 1|Test 2
Gui, Add, Tab3, xs+1 -Theme vTabGrupa1, TEST|TEST 2|TEST 3|TEST 4
Gui, Tab
Gui, Add, Tab3, xm+0 -Theme vTabGrupa2, Szablon 1|Szablon 2|Szablon 3|Szablon 4
Gui, Show
Return

Grupa:
{
  Gui, Submit, nohide
  if (Lista = "Test 1")
  {
    GuiControl, Hide, TabGrupa2
    GuiControl, Hide, TabGrupa3
    GuiControl, Hide, TabGrupa4
    GuiControl, Show, TabGrupa1
  }
  else if (Lista = "Test 2")
  {
    GuiControl, Hide, TabGrupa1
    GuiControl, Hide, TabGrupa3
    GuiControl, Hide, TabGrupa4
    GuiControl, Show, TabGrupa2
  }
}
return

GuiClose:
ExitApp

[lexikos]

The issue appears to be WM_SETREDRAW. For instance, this appears to make it work:

Code: Select all

OnMessage(0xB, "WM_SETREDRAW")
WM_SETREDRAW(wParam) {
    if !wParam
        return 0
}

WM_SETREDRAW is used to prevent incremental redrawing while the individual child controls are being shown or hidden. I think what happens is this:

• When the first Tab is shown or hidden, its region of the GUI is invalidated.
• When the second Tab is shown or hidden, it disables redraw by sending WM_SETREDRAW, FALSE.
• WM_SETREDRAW probably has the effect of clearing out the window's update region (such as by calling ValidateRect()).
• Only the region occupied by the second Tab is redrawn.

v1.1.27.07 fixes it by using GetUpdateRect() prior to disabling redraw and an additional call to InvalidateRect() after enabling redraw (except in cases where a child control lies partially outside the bounds of the Tab, since in that case the entire GUI is invalidated).