There must be a better way of doing this :) Topic is solved

[WalkerOfTheDay]

Hi,

I have this code where I want to disable certain gui buttons if certain script(s) is / are not running.
It works like intended, but I have a feeling there must be a better way of doing it.
I feel like repeating the same code for every button is a bit inefficient.

Code: Select all

SetTimer, CheckScript, 5000
SetTimer, CheckScript2, 5000

CheckScript:

IfWinNotExist, SRT Cloud afmelden.ahk
{
	GuiControl, disable, Script5
}
Else 
{
	GuiControl, enable, Script5
}
CheckScript2:
IfWinNotExist, TSI Cloud afmelden.ahk
{
	GuiControl, disable, Script6
}
Else 
{
	GuiControl, enable, Script6
}
return

(I know the curly brackets are not required, but that's the way I like to code ).

[Blackholyman]

try this

Code: Select all

scripts := ["Script1name.akk","Script2name.ahk","Script3name.ahk","Script4name.ahk","SRT Cloud afmelden.ahk","TSI Cloud afmelden.ahk"]
SetTimer, CheckScript, 5000

CheckScript:
for i, name in scripts
{
   IfWinNotExist, %name%
      GuiControl, disable, Script%i%
   Else 
      GuiControl, enable, Script%i%
}
return

[WalkerOfTheDay]

Thanks Blackholyman,

It works, but I don't really like that you have to add these 4 fake scripts in the code.
What if I had a gui button that doesn't contain a number ?

[BoBo]

Code: Select all

Loop 
{
    CheckScript("SRT Cloud afmelden.ahk",5,10)          ; window title, script number, seconds to wait (optional)
    CheckScript("TSI Cloud afmelden.ahk",6,3)
    }

CheckScript(wintitle,sNo,s=5){                          ; if 3rd paramter is missing 5 seconds to wait (default)
    toggle := (WinExist(wintitle)=0) ? "enable":"disable"   ; if window title not exist (=0) is true, enable else disable
    GuiControl, %toggle%, Script%sNo%
    Sleep % s*1000
    Return
    }

!x::ExitApp
    

Not tested (I'm away from my desk). Good luck

[WalkerOfTheDay]

Nice approach, I see what you're doing there It is throwing an error though.

The error is:

Warning: This variable has not been assigned a value.

Specifically: enable (a global variable)

[BoBo]

Nice approach, I see what you're doing there It is throwing an error though.

The error is:

Warning: This variable has not been assigned a value.

Specifically: enable (a global variable)

that should do the trick ... "enable" : "disable"

[WalkerOfTheDay]

Yes !

It's working, it only was doing the opposite of what I wanted

So I changed:

Code: Select all

toggle := (WinExist(wintitle)=0) ? "enable":"disable"   ; if window title not exist (=0) is true, enable else disable

To:

Code: Select all

toggle := (!WinExist(wintitle)=0) ? "enable":"disable"   ; if window title not exist (=0) is true, enable else disable

Thank you so much. I love this community !

[WalkerOfTheDay]

Spoke to soon, the loop prevent the rest op the script from executing. So when I press any of the
buttons, nothing happens.

I think I need to somehow replace the loop with a timer.
I'll try to find the sollution myself. If I fail I'll get back to this thread

I did it

Code: Select all

CheckScript(wintitle,sNo,s=5) ; if 3rd parameter is missing 5 seconds to wait (default)
{                              
	toggle := (!WinExist(wintitle)=0) ? "enable":"disable"   ; if window title not exist (=0) is true, enable else disable
	GuiControl, %toggle%, Script%sNo%
	Sleep % s*1000
	Return
 }


SetTimer, ReloadButton, 1000

ReloadButton:
    	CheckScript("SRT Cloud afmelden.ahk",5,1)          ; window title, script number, seconds to wait (optional)
   	CheckScript("TSI Cloud afmelden.ahk",6,1)
	return