Need a little help with Loop

[euras]

I try to add an extra row if the result in the loop is correct. If I try to do manually, the new row will appear. If I try to do that via Loop, the new row will not appear. What I'm doing wrong?

Code: Select all

linas1 = some random text
if (linas1 <> "")
	linas1 = %linas1%`n`n ; in that situation I get the new row
Loop, 1
{
	if (linas[A_Index] <> "")
		linas[A_Index] = %linasA_Index%`n`n ; here I don't get any new row
}	
sikk = %linas1%
msgbox, %sikk%

[evilC]

It's nothing to do with the loop
linas1 is a pseudo-array, not a real array. You cannot access elements of a pseudo-array with arr[index] syntax.

Code: Select all

	if (linas%A_Index% <> "")
		linas%A_Index% = linas%A_Index%`n`n

If you have no reason to be using pseudo-arrays (ie you are not trying to use a command that needs pseudo-arrays), then avoid them like the plague, they are horrid and should be burned with fire IMHO.

I would write the code thus:

Code: Select all

linas := ["some random text"]
Loop, 1
{
	if (linas[A_Index] <> "")
		linas[A_Index] .= "`n`n"
}	
sikk = linas[1]
msgbox, % sikk

[euras]

It's nothing to do with the loop

Oh, now I see... Your example works, but it doesn't fit in my code.. I have to use clipboard as a source of data and there can be more than 1 value then. I have tried to add it to my code but without result :/ It could be nice to learn to use that method, because now I need to create many extra lines for each possible scenario...

Code: Select all

page := clipboard
nsutr = 0
Loop , parse , page, `n, %A_Space%%A_Tab%
{
	line := A_LoopField
	if line contains TTE: ; now the right line has been found, parse that line
	{
		lina%A_Index% := A_LoopField
		++nsutr
		linas%nsutr% := lina%A_Index%
	}
}
Loop, 10
{
	if (linas[A_Index] <> "")
		linas[A_Index] .= "`n`n"
	if (linas[A_Index] = "")
		linas[A_Index] := ""
}
sikk := linas[1]linas[2]linas[3]linas[4]linas[5]linas[6]linas[7]linas[8]linas[9]linas[10]
msgbox, % sikk
return

[evilC]

You can split a string into a proper array using StrSplit()

Code: Select all

lines := StrSplit(clipboard, "`n")
Loop % lines.length(){
	line := lines[A_Index]
	...
}

[BoBo]

... then avoid them like the plague, they are horrid and should be burned with fire IMHO.

[euras]

I did it that way:

Code: Select all

nsutr = 0
Loop , parse , page, `n, %A_Space%%A_Tab%
{
	line := A_LoopField
	if line contains TTEXT: ; now the right line has been found, parse that line
	{
		lina%A_Index% := A_LoopField
		++nsutr
		linas%nsutr% := lina%A_Index%
		linas := [ linas%nsutr% ]
	}
Loop, %nsutr%
{
	if (linas%A_Index% <> "")
		linas%A_Index% .= "`n"
	if (linas%A_Index% = "")
		linas%A_Index% =
}
sikkeras2 = %linas1%%linas2%%linas3%%linas4%
Msgbox, % sikkeras2

[BoBo]

As evilC has already advised use StrSplit() instead of dealing with a Loop creating a pseudo-array.
Additionally to that you should have a look at InStr() and how to use a ternary-operator.
Good luck

[evilC]

Also be aware that this syntax is all fine and well when alone on one line, but does something quite specific when used within a command:

++nsutr

If you had code like this:

Code: Select all

nustr := 1
SomeFunc(++nsutr)

Then somefunc would be called with the value 2, not 1
++var means "increment and THEN use".

It's far more common to use nsutr++ ("Use and THEN increment")

[euras]

thank you for your advices guys, it will help me to improve my AHK skills

[evilC]

You're welcome. Always happy to help people who want to learn.