Opening folders

[MauroG]

I have a script to have hotkeys for specific folders, like:

Code: Select all

^!d::
{
	Run C:\Documents\
	WinWait, Documents
	Gosub, Center
	Return
}

where "Center" is:

Code: Select all

Center:
{
	WinGetPos, , , WinW, WinH, A
	WinMove, A, , A_ScreenWidth/2-WinW/2, A_ScreenHeight/2-WinH/2-60
	Return
}

to center it in the screen. It works quite fine, but since I switched to Win10 (from XP) sometime it just seems to freeze: after I opened a folder, that same folder doesn't open anymore (but the rest do), and for it to work properly I have to restart Windows Explorer services and the script itself. I can't replicate it, it just happens sometime.

When it happens, the current windows loses focus after regaining it, so it seems it's trying to open the folder; I think it could depend on WinWait instruction, but I'm not sure: for some reason maybe Run doesn't work, and the script get stuck waiting for the folder; if I change from

Code: Select all

WinWait, Documents

to

Code: Select all

WinWait, Test

I have the same issue.

I also tried to open the folder manually, hoping if the issue was the WinWait it'd be solved, but it didn't, I still had to restart Explorer and script.

[BoBo]

Probably a timing issue. What about to use WinWaitActive instead of WinWait?

[MauroG]

I'll try that and keep you updated, thanks!

[MauroG]

Unfortunately it's not that, also with WinWaitActive it freezes like before.

[MaxAstro]

Try adding a timeout to WinWaitActive, and have the script display an error and return if the timeout triggers.

[MauroG]

It did trigger, so it was WinWaitActive, so maybe it does is Run not opening the folder and WinWaitActive looping for that. Ideas? Maybe adding a Return in case of error, but if there were a way to prevent the error altogether would be great.

[MauroG]

It keeps happening, unfortunately the timeout doesn't seem to stop the loop.

[Vh_]

post your code that is failing.

[MauroG]

It's this code:

Code: Select all

^!d::
{
	Run C:\Documents\
	WinWaitActive, Documents,,1
	Gosub, Center
	Return
}

where "center" is:

Code: Select all

Center:
{
	WinGetPos, , , WinW, WinH, A
	WinMove, A, , A_ScreenWidth/2-WinW/2, A_ScreenHeight/2-WinH/2-60
	Return
}

It doesn't happen often, but sometimes it just freeze as described above. The same issue happens with WinWait instead that WinWaitActive.

[jeeswg]

One possible issue is if there is already a window called 'Documents' open.

You could do something like:

Code: Select all

IfWinExist, Documents
	WinActivate, Documents
else
{

}

I would try this for your code so far:

Code: Select all

^!d::
{
	Run, C:\Documents
	WinWait, Documents
	;WinWaitActive, Documents ;you could use this line instead
	Gosub, Center
	return
}

Center:
{
	WinGetPos,,, WinW, WinH, Documents
	WinMove, Documents,, % A_ScreenWidth/2-WinW/2, % A_ScreenHeight/2-WinH/2-60
	return
}
return

[MauroG]

One possible issue is if there is already a window called 'Documents' open

That's not the case, the issue happened without windows with the same name being already opened.

Code: Select all

I would try this for your code so far:
[code]
^!d::
{
	Run, C:\Documents
	WinWait, Documents
	;WinWaitActive, Documents ;you could use this line instead
	Gosub, Center
	return
}

Center:
{
	WinGetPos,,, WinW, WinH, Documents
	WinMove, Documents,, % A_ScreenWidth/2-WinW/2, % A_ScreenHeight/2-WinH/2-60
	return
}
return

Using WinWait instead of WinWaitActive doesn't resolve the issue (it was the first version of the code, see opening post); as for Center, I use A instead of Documents because several shortcut calls it (Documents, Work, etc.), so I can't have a fixed name.

I think I'll have to go for an If version; thanks for the suggestions!

[jeeswg]

If Center must be applied to the active window, I would do this:

Code: Select all

^!d::
{
	Run, C:\Documents
	WinWait, Documents ;possibly add the timeout parameter, and some code to handle a timeout
	WinActivate, Documents
	;WinWaitActive, Documents
	Gosub, Center
	return
}

Center:
{
	WinGetPos,,, WinW, WinH, A
	WinMove, A,, % A_ScreenWidth/2-WinW/2, % A_ScreenHeight/2-WinH/2-60
	return
}

[MauroG]

Will try that, thanks; but the issue being the folder (Documents in this example) don't even open and WinWait timeout, would WinActivate do anything? I was thinking about using something like if there is an error, return, if nothing else works.

[MauroG]

I was thinking about doing another subroutine before center, that checks ErrorLevel and stops WinWaitActive if there is an error; any idea how to do this? Using Return in the subroutine stops the subroutine itself, not sure how to say to stop WinWaitActive.

[DyaTactic]

You can use the timeout feature of WinWaitActive:
WinWaitActive, Documents, , 2
This waits only 1 second to activate the window, when the window is still not active ErrorLevel is set to 1. Following the command with a ‘If ErrorLevel’ line allows to take action when something is wrong.

Code: Select all

WinWaitActive, Documents, , 2	; Wait 2 seconds for the window to activate.
If ErrorLevel
{
	; Something to do on error.
}

[MauroG]

Yup, my idea was to put the If ErrorLevel part in a subroutine, since I would have to use it with the same effect more than once and it'd be simple to define one subroutine and call it, rather then having If ErrorLevel each time; it's possible to do so?

[DyaTactic]

Like

Code: Select all

; ...
WinWaitActive, Documents, , 2	; Wait 2 seconds for the window to activate.
GoSub, CheckErrorLevel

Return

CheckErrorLevel:
If ErrorLevel
{
	; Something to do on error.
} Else {
	; Something to do on succes.
}
Return

?
Yes, that is possible.

[MauroG]

If I want it to just stop WinWaitActive what should I do? I think something like this:

Code: Select all

CheckErrorLevel:
If ErrorLevel
{
	Return
}
Return

would just return from the subroutine to the main script, but would it stop the loop?

(I'm trying to see if the subroutine works, but since I can't reproduce the glitch I have to wait for it to happens.)

[DyaTactic]

To reproduce the glitch you can change toe WinTitle form Documents to ‘Nonexisitingswindowsorsomethinglikethis’.
You last post will only return to the lines under the ‘GoSub, CheckErrorLevel’ command.
What you want is accomplished with just

Code: Select all

WinWaitActive, , , 2
If ErrorLevel
	Return

[Guest]

It doesn't seem to work, no idea why; this is the code:

Code: Select all

^!d::
{
	Run C:\Documents\
	WinWaitActive, F,,1
	Gosub, CheckErrorLevel
	Gosub, Center
	Return
}

Center:
{
	WinGetPos, , , WinW, WinH, A
	WinMove, A, , A_ScreenWidth/2-WinW/2, A_ScreenHeight/2-WinH/2-60
	Return
}

CheckErrorLevel:
{
	If ErrorLevel
		MsgBox, Text
	Return
}

It opens the folder without showing the textbox.