Any help converting this to expression syntax?

[evilC]

I found some code in bug.n that provides a WinMove equivalent that works properly with AeroSnap, however the code uses assume-global and horrid syntax - I am trying to re-write it.

However, I am stuck on this line, I cannot work out what the logic actually means:

Code: Select all

If Not wndId Window_getPosEx(wndId, wndX, wndY, wndW, wndH) And (Abs(wndX - x) < 2 And Abs(wndY - y) < 2 And Abs(wndW - width) < 2 And Abs(wndH - height) < 2)
    Return, 0

It's the If Not wndId Window_getPosEx bit at the start which is totally baffling me. WTF is this saying??

https://github.com/fuhsjr00/bug.n/blob/ ... w.ahk#L247

[jNizM]

For me it looks like this in ahk ^^

Code: Select all

if !(wndId := Window_getPosEx(wndId, wndX, wndY, wndW, wndH))
&&  (Abs(wndX - x) < 2)
&&  (Abs(wndY - y) < 2)
&&  (Abs(wndW - width) < 2)
&&  (Abs(wndH - height) < 2)
    return 0

btw.. his coding style is horrible ^^

[evilC]

wndId := Window_getPosEx Does Window_getPosEx not return a RECT?

[jNizM]

His coding style is horrible ^^

Code: Select all

Window_getPosEx(hWindow, ByRef X = "", ByRef Y = "", ByRef Width = "", ByRef Height = "", ByRef Offset_X = "", ByRef Offset_Y = "") {
	; ...
	return &RECTPlus
}

Code: Select all

Window_move(wndId, x, y, width, height) {
	if !(wndId) ????????? Window_getPosEx(wndId, wndX, wndY, wndW, wndH)    ; <- this makes no sense
	&&  (Abs(wndX - x) < 2)
	&&  (Abs(wndY - y) < 2)
	&&  (Abs(wndW - width) < 2)
	&&  (Abs(wndH - height) < 2)
		return 0
}

Code: Select all

if !(wndId)
??  Window_getPosEx(wndId, wndX, wndY, wndW, wndH)    ; <- should be ! (not addr)
&&  (Abs(wndX - x) < 2)
&&  (Abs(wndY - y) < 2)
&&  (Abs(wndW - width) < 2)
&&  (Abs(wndH - height) < 2)

or better this way:

Code: Select all

Window_getPosEx(wndId, wndX, wndY, wndW, wndH)

if !(wndId)
&&  (Abs(wndX - x) < 2)
&&  (Abs(wndY - y) < 2)
&&  (Abs(wndW - width) < 2)
&&  (Abs(wndH - height) < 2)

[evilC]

So it is returning the address of a RECT?

[jNizM]

This is what I expect

Code: Select all

addr := Window_getPosEx(wndId, wndX, wndY, wndW, wndH)

if !(wndId)
&& !(addr)
&&  (Abs(wndX - x) < 2)
&&  (Abs(wndY - y) < 2)
&&  (Abs(wndW - width) < 2)
&&  (Abs(wndH - height) < 2)

[evilC]

It seems to work, but I am not totally sure what that part of the code is doing. I think it only triggers if something basically goes wrong?

[just me]

Code: Select all

wndId Window_getPosEx(wndId, wndX, wndY, wndW, wndH)

is not an assignment for wndId, but it might be auto-concatenated.

[evilC]

Well I implemented the code in my window tiler, and it is certainly an improvement.

[just me]

Well, I think the bug.n's code is somewhat buggy. Window_getPosEx() returns an address evaluating to True in every case. (Also, the returned address is somewhat useless because it's an address of a local var and the first TCHAR of its stringbuffer is set to NULL when the function returns.)

Neither

Code: Select all

Not wndId Window_getPosEx(wndId, wndX, wndY, wndW, wndH)

nor

Code: Select all

!(wndId) && !(addr)

will ever evaluate to True.

If you change Window_getPosEx() to return True/False depending on the result of the DllCalls, this might make sense:

Code: Select all

	if (!(wndId) || !(addr) ||  (Abs(wndX - x) < 2) ||  (Abs(wndY - y) < 2) &&  (Abs(wndW - width) < 2) &&  (Abs(wndH - height) < 2))
		return 0