Choosecolor function works in 1.1.24. Fails in 1.1.27.

[joefiesta]

I feel this is bug, but I have learned to not jump the gun, so I'm starting in this forum.

The subject script is from the old AHK forum, here: https://autohotkey.com/board/topic/7984 ... ems/page-6 It works fine in AHK 1.1.24.03. It causes a Windows 0xC0000005 crash in 1.1.27.00.
The script fails in the

Code: Select all

Loop 64 ; Compare data CUS2 and CUS1, if custom color changed, then save array to BIN file

loop. I did not narrow it down to exactly where and when.

I am running Windows 7 Pro. I have been using this script for many, many years. Only now, 1.1.27.00 is it a problem. Do you agree this is an AHK bug?

The script fails 100% of time when you choose the "Change Background Color" button, change the color and hit "OK". Here is the data reported by Windows:

Problem signature:
Problem Event Name: APPCRASH
Application Name: AutoHotkey.exe
Application Version: 1.1.27.0
Application Timestamp: 5a40413c
Fault Module Name: AutoHotkey.exe
Fault Module Version: 1.1.27.0
Fault Module Timestamp: 5a40413c
Exception Code: c0000005
Exception Offset: 00060088
OS Version: 6.1.7601.2.1.0.256.48
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789


Here is the script.

Code: Select all

Gui, Add, Button, x200 y275 w150 gChangeBG, Change BackGround Color
Gui, Show, , ChooseColor() Demo
Return

ChangeBG:
 GuiColor := ChooseColor( GuiColor, WinExist() )
 IfGreaterOrEqual,GuiColor,0, Gui,Color,%GuiColor%
Return

GuiClose:
 ExitApp
Return

ChooseColor( Color=0x0, hPar=0x0, ccFile="")  {
Color := SubStr(Color,1,2)="0x" ? Color : "0x" Color      ; Check & Prefix Color with "0x"
VarSetCapacity(CHOOSECOLOR, 36, 0) , mainPtr := (&CHOOSECOLOR)     ; Create Main structure
DllCall( "RtlFillMemory", UInt,mainPtr+0, Int,1, UChar,36 ) ; Insert size of the Structure

hPar := WinExist(ahk_id %hPar%) ; Validate the passed Parent window ID
; Break Parent window ID into 4 bytes
H1 := hPar>>0 & 255,   H2 := hPar>>8 & 255,   H3 := hPar>>16 & 255,   H4 := hPar>>24 & 255
Loop 4                       ; Insert Parent window ID to CHOOSECOLOR structure @ Offset 4
  DllCall( "RtlFillMemory", UInt,mainPtr+3+A_Index, Int,1, UChar,H%A_Index% )

; Break Color into R,G and B values
RGB1 := Color>>16 & 255,    RGB2 := Color>>8  & 255,    RGB3 := Color>>0  & 255
Loop 3                      ; Insert R,G and B values to CHOOSECOLOR structure @ Offset 12
  DllCall( "RtlFillMemory", UInt,mainPtr+11+A_Index, Int,1, UChar,RGB%A_Index% )

; CustomColors ( CUS1 will be primary array and CUS2 will be a copy to detect any change )
VarSetCapacity(CUS1, 64, 0),   aPtr := (&CUS1),   VarSetCapacity(CUS2, 64, 0)
IfEqual,ccFile,, SetEnv,ccFile,%A_WinDir%\CUSTOMCOLOR.BIN ; Assign default save filename
IfExist,%ccFile%,  FileRead,CUS1, *m64 %ccFile%           ; Array CUS1 will be overwritten
Loop 64                                                   ; Copy data from CUS1 to CUS2
 oS:=A_Index-1, DllCall( "RtlFillMemory", UInt,&CUS2+oS, Int,1, UChar,*(&CUS1+oS) )
A1 := aPtr>>0 & 255,   A2 := aPtr>>8 & 255,   A3 := aPtr>>16 & 255,   A4 := aPtr>>24 & 255
Loop 4        ; Insert pointer to Custom colors array to CHOOSECOLOR structure @ Offset 16
   DllCall( "RtlFillMemory", UInt,mainPtr+15+A_Index, Int,1, UChar,A%A_Index% )

; Insert Integer 259 @ Offset 21 (259 is CC_RGBINIT + CC_FULLOPEN + CC_ANYCOLOR )
DllCall( "RtlFillMemory", UInt,mainPtr+20, Int,1,UChar,3  ) ; CC_RGBINIT=1 + CC_FULLOPEN=2
DllCall( "RtlFillMemory", UInt,mainPtr+21, Int,1,UChar,1  ) ; CC_ANYCOLOR=256

If ! DllCall("comdlg32\ChooseColorA", str, CHOOSECOLOR) OR errorLevel   ; Call ChooseColor
     Return -1            ; and return -1 in case of an error or if no color was selected.

Loop 64 ; Compare data CUS2 and CUS1, if custom color changed, then save array to BIN file
  If ( *(&CUS1+A_Index-1) != *(&CUS2+A_Index-1) )   {       ; Check byte by byte
       h := DllCall( "_lcreat", Str,ccFile, Int,0 )         ; Overwrite/create file
            DllCall( "_lwrite", UInt,h, Str,CUS1, Int,64 )  ; write the array,
            DllCall( "_lclose", UInt,h )                    ; close the file,
            Break                                           ; break the loop.
                                                    }
Hex := "123456789ABCDEF0",   RGB := mainPtr+11
Loop 3 ; Extract nibbles directly from main structure and convert it into Hex (initd. abv)
  HexColorCode .=  SubStr(Hex, (*++RGB >> 4), 1) . SubStr(Hex, (*RGB & 15), 1)
Return HexColorCode ; finally ... phew!
}

[noname]

Found no problem win10 pro

[JoeWinograd]

Works perfectly here on W7 Pro SP1 64-bit with AHK U32 1.1.27.02:

ChooseColor test.gif (8.12 KiB) Viewed 803 times

Regards, Joe

[just me]

I feel this is bug, but I have learned to not jump the gun, so I'm starting in this forum.

Well done!

Your version of ChooseColor() is 32-bit only and technically out-dated.

[joefiesta]

Thanks for taking the time to look at this to everyone who replied.

The fact that you verified it worked on your systems further validated that something was wrong with AutoHotKey 1.1.27.00 (although it would have been great if someone had actually tried it on that EXACT version.) So, I delved further.

Yes, THIS IS A BUG!!! But, it's already been fixed. The bug was specific to 1.1.27.00 and only 1.1.27.00.

For the record, I made one mistake. The code in error was not the "LOOP 64" and it's contents. The code in error was the subsequent loop

Code: Select all

Loop 3 ; Extract nibbles directly from main structure and convert it into Hex (initd. abv)
  HexColorCode .=  SubStr(Hex, (*++RGB >> 4), 1) . SubStr(Hex, (*RGB & 15), 1)

In the release notes for 1.1.27.01 is

Fixed program crashes caused by ++X or --X in scripts which lack #NoEnv (broken by v1.1.27.00).

Voila. Adding #noenv fixed the script. Nice release note (Lexikos, I assume)!!!