trying to grab a file from ftp with date variable name

[schnarkle]

Hi I'm trying to download a file every day by today's date. The format is MTR_040518.pdf.

Here is the code:

Code: Select all

WinClose, ahk_class AcrobatSDIWindow

Sleep, 1000

WinClose, ahk_class AcrobatSDIWindow

SetWorkingDir, C:\


FormatTime, MyFile,, 'MTR_'MM''dd''yy'.pdf'


RunWait % "curl.exe -v -o c:\scripts\%MyFile% ftp://ftp.themonitor.com/lobby/%MyFile% --user username:password"

Sleep, 20000


Run, c:\scripts\%MyFile%

Sleep, 20000

Send ^l

Sleep, 20000

Send ^2


Pause

But I get the error here when running? It looks like it's outputting the name correctly but the file is not being downloaded even though it is there and named exactly like the script seems to show.

why.png (22.73 KiB) Viewed 1198 times

any ideas please?

[neverlevel]

i dont think its not getting the file...i think maybe its not running curl??

[schnarkle]

It is running curl because if I manually type the filename in the script without the date variable (MTR_040518.pdf literal) it works.
Maybe autohotkey sees the date variable one way but curl in another?

thanks

[FanaticGuru]

RunWait % "curl.exe -v -o c:\scripts\" MyFile " ftp://ftp.themonitor.com/lobby/" MyFile " --user username:password"

%MyFile% inside quotes will not be expanded. Everything in "Quotes" is literal. So you are literally trying to download and create a file named "%MyFile%".

Or you could do this:
RunWait curl.exe -v -o c:\scripts\%MyFile% ftp://ftp.themonitor.com/lobby/%MyFile% --user username:password

FG

[BoBo]

Code: Select all

%MyFile% inside quotes will not be expanded. Everything in "Quotes" is literal. So you are literally trying to download and create a file named "%MyFile%".

... and the reason for that, you've initialized a [forced expression]

Force an expression: An expression can be used in a parameter that does not directly support it (except OutputVar parameters) by preceding the expression with a percent sign and a space or tab. In [v1.1.21+], this prefix can be used in the InputVar parameters of all commands except the traditional IF commands (use If (expression) instead). This technique is often used to access arrays.