Center Image

[empardopo]

I've found the next script to center an image on the screen

Code: Select all

Gui, Margin, 0,0
Gui 1:-owner -toolwindow -caption +LastFound
Gui, Add, Picture, vMyPic, C:\Documents and Settings\Administrador\Escritorio\Letras\A.png-1.jpg
Gui, Show, % "W" . A_ScreenWidth . " H" . A_ScreenHeight . " X0 Y0", My GUI
GuiControlGet, Pic, Pos, MyPic
xx := (A_ScreenWidth-picw)/2
yy := (A_ScreenHeight-pich)/2
GuiControl, MoveDraw, MyPic, x%xx% y%yy%
WinSet,Transparent,0 ,My GUI
Return

ESC::
GuiClose:
Gui, Destroy
;ExitApp 

I want to convert in a function,

Code: Select all

SetWorkingDir %A_ScriptDir% 

;imagen = Teclado-Spectrum.png
CentrarImagen(Teclado-Spectrum.png)
return

CentrarImagen(nombreImagen)
{
Gui, Margin, 0,0
Gui 1:-owner -toolwindow -caption +LastFound
Gui, Add, Picture, vMyPic, nombreImagen
Gui, Show, % "W" . A_ScreenWidth . " H" . A_ScreenHeight . " X0 Y0", My GUI
GuiControlGet, Pic, Pos, MyPic
xx := (A_ScreenWidth-picw)/2
yy := (A_ScreenHeight-pich)/2
GuiControl, MoveDraw, MyPic, x%xx% y%yy%
WinSet,Transparent,0 ,My GUI
Return
}



ESC::

GuiClose:
Gui, Destroy
;ExitApp 

What is the wrong? I get Error: A control's variable must be global or static in the line
Gui, Add, Picture, vMyPic, nombreImagen

I don't know where is my problem.

Thanks!

[LinearSpoon]

Inside the function, a newly declared variable (MyPic) is considered "local". The easiest fix would be to use 'global MyPic' as the first line of the function. Also nombreImagen should be in %% when you add the picture.

Code: Select all

CentrarImagen(nombreImagen)
{
Global MyPic
Gui, Margin, 0,0
Gui 1:-owner -toolwindow -caption +LastFound
Gui, Add, Picture, vMyPic, %nombreImagen%
Gui, Show, % "W" . A_ScreenWidth . " H" . A_ScreenHeight . " X0 Y0", My GUI
GuiControlGet, Pic, Pos, MyPic
xx := (A_ScreenWidth-picw)/2
yy := (A_ScreenHeight-pich)/2
GuiControl, MoveDraw, MyPic, x%xx% y%yy%
WinSet,Transparent,0 ,My GUI
Return
}

Also, in the line CentrarImagen(Teclado-Spectrum.png), the picture file should be in quotations like so:

Code: Select all

CentrarImagen("Teclado-Spectrum.png")

[empardopo]

That should be the only combination I had not tried ...
Do not quite understand but now works fine.

Thanks very much!

[Alibaba]

Have you read this?
http://l.autohotkey.net/docs/Functions.htm#Locals

Maybe it'll help you to understand the different variable modes.