[2.0.10] LV.Opt("+NoSort") doesn't work! Topic is solved

[just me]

As the subject says ...

Related: viewtopic.php?p=548830#p548830

[denis_q2]

script_gui.cpp

Code: Select all

2727 ResultType GuiType::AddControl(GuiControls aControlType, LPCTSTR aOptions, LPCTSTR aText, GuiControlType*& apControl, Array *aObj)
2981     if (!ControlParseOptions(aOptions, opt, control))
4090     control.union_lv_attrib->no_auto_sort = opt.listview_no_auto_sort;

Code: Select all

 769 FResult GuiControlType::Opt(StrArg aOptions)
 774 if (!gui->ControlParseOptions(aOptions, go, *this, GUI_HWND_TO_INDEX(hwnd)))

Could it be because the assignment corresponding to line 4090 is missing in 'GuiControlType::Opt'?

[lexikos]

An unconditional assignment would cause NoSort to be undone if Opt is called without that option (e.g. to set some other option). The change to no_auto_sort needs to be made inside ControlParseOptions, which can differentiate between the presence of -NoSort and the absence of NoSort in some other string of options. See commit cc356bc6.

[lexikos]

Fixed by v2.0.11.